Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve types around User in schema and client #18645

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Improve types around User in schema and client #18645

merged 4 commits into from
Aug 6, 2024

Conversation

davelopez
Copy link
Contributor

@davelopez davelopez commented Aug 5, 2024 •
edited
Loading

Part of #18532

  • Improve types for quota fields in API schema
  • Use generated schema models for RegisteredUser and AnonymousUser
  • Refactor ownership checks based on username to go through the userStore using the correct types
  • Use correct types for registered users in client tests

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@davelopez davelopez added kind/enhancement area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes area/API labels Aug 5, 2024
@github-actions github-actions bot added this to the 24.2 milestone Aug 5, 2024
@davelopez davelopez marked this pull request as draft August 5, 2024 09:01
@davelopez davelopez force-pushed the improve_user_types branch from 01227d4 to 83c7d0e Compare August 5, 2024 14:22
@davelopez davelopez marked this pull request as ready for review August 5, 2024 16:43
@davelopez
Copy link
Contributor Author

Integration test failures are unrelated.

@mvdbeek mvdbeek merged commit 4f20fbf into galaxyproject:dev Aug 6, 2024
54 of 57 checks passed
@davelopez davelopez deleted the improve_user_types branch August 6, 2024 10:55
@davelopez davelopez mentioned this pull request Aug 9, 2024
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/API area/UI-UX kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.
2 participants
@davelopez @mvdbeek